-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add permanent id label to pp/cpp/rb/crb/work resources #4474
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4474 +/- ##
==========================================
+ Coverage 51.76% 51.82% +0.06%
==========================================
Files 250 250
Lines 24980 25008 +28
==========================================
+ Hits 12930 12961 +31
+ Misses 11340 11338 -2
+ Partials 710 709 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -158,6 +160,8 @@ func Run(ctx context.Context, opts *options.Options) error { | |||
hookServer.Register("/mutate-multiclusterservice", &webhook.Admission{Handler: &multiclusterservice.MutatingAdmission{Decoder: decoder}}) | |||
hookServer.Register("/mutate-federatedhpa", &webhook.Admission{Handler: &federatedhpa.MutatingAdmission{Decoder: decoder}}) | |||
hookServer.Register("/validate-resourcedeletionprotection", &webhook.Admission{Handler: &resourcedeletionprotection.ValidatingAdmission{Decoder: decoder}}) | |||
hookServer.Register("/mutate-resourcebinding", &webhook.Admission{Handler: &resourcebinding.MutatingAdmission{Decoder: decoder}}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if adding this is reasonable, but it seems it can also be handled in the controller without adding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little bit complex and difficult to maintain the code in controller, I prefer to add this in weebhook, not in controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @RainbowMango
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chaunceyjiang What's your concern?
I can tell a challenge for the user to update the MutatingWebhookConfiguration
during upgrading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I waiting for @chaunceyjiang about this :)
/cancel lgtm |
It looks good to initialize the label by webhook, however, I think there is no rush to do it. As the label name might be changed. I feel the label name might not be prefixed with a
But it should be something like:
I feel it isn't right for each |
/hold |
@RainbowMango, any plan to move forward? Is it currently on hold for more discussions? We are waiting for a solution for issue. |
Current progress on the issue: #4683 (comment) |
If we want to change the label name, we can remove the previously used namespace/name related labels at least in the next version (v1.11), and solve the problem described in #4000. Is this progress as expected? |
Yeah, thanks for the reminder. Let's move forward and if we decide to rename the label in the future, we can run another deprecation cycle. |
@jwcesign Can you help to rebase this PR? And, shall we update the MutatingWebhookConfiguration along with this? |
This PR is missing the webhook-configuration file. |
0782df5
to
c35a999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c35a999
to
284749d
Compare
223af34
to
a542ad5
Compare
@XiShanYongYe-Chang The test is failing, please take a look. |
I'm working on it. |
The current PR can be pushed after the modification of |
a542ad5
to
1ba3921
Compare
Signed-off-by: jwcesign <jwcesign@gmail.com>
1ba3921
to
6a54a9a
Compare
/cc @RainbowMango It is ready to merge now. |
Uh, please propose a release notes... |
How about
I added a sub-task to the task item of #4711 to describe this. |
/cc @RainbowMango |
Kindly ping @RainbowMango @chaunceyjiang |
/assign @chaunceyjiang @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Please referring to: #4000 and #4199 (comment)
Which issue(s) this PR fixes:
Part of #4000
Special notes for your reviewer:
The corresponding yaml configuration will be done in another PR.
Does this PR introduce a user-facing change?: